Add well known PortalTarget class and examples #334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
PortalTarget
(as discussed) as a well known class that can be used to globally customize the default portal target used by the portal action.I also:
I expect this was just an oversight so far. If a portal is initially disabled, it just stays in its original parent, so it seems to make sense to consider that its "disabled state". And if a user doesn't want the portal to move, they just shouldn't change the options.
I primarily made the change, because it meant that I needed less code for the examples, but I think that it's the intuitive behaviour.