CopyButton enhancements #346
Conversation
🦋 Changeset detectedLatest commit: 5686823 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dimfeld
force-pushed
the
copybutton-function
branch
from
83a0921 to
110617f
Compare
dimfeld
changed the title
| showMessage = true; | ||
| let copyValue = typeof value === 'function' ? value() : value; | ||
| navigator.clipboard.writeText(copyValue); | ||
| dispatch('click'); |
There was a problem hiding this comment.
Instead of using dispatch maybe just add another on:click to forward the event. It's a pattern I've used elsewhere (NavItem, ToggleButton)
There was a problem hiding this comment.
Yeah I go back and forth on that. Ended up doing it this way to be more explicit about the event firing after the clipboard has been copied, instead of relying on the undocumented behavior that the event handlers fire in the order they are listed in the template. (Not that it's likely to change at this point)
Also this is very slightly closer to how it will be in Svelte 5. :) Anyway I can change it if you still would like me to.
There was a problem hiding this comment.
Nope, makes sense to me to have the explicit ordering, especially to align with how things will be going forward with Svelte 5, which I believe becomes...
<script>
const { onclick } = $props;
</script>
<Button
onclick={() => {
// ...
onclick();
}}
/>(or something like that. just wrote that in a github comment without checking too much).
valueto be a function that returns a stringclickevent when the button is clicked