Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generator delegate (#231) #319

Merged
merged 6 commits into from
May 21, 2023
Merged

Conversation

philprime
Copy link
Member

@philprime philprime commented Dec 17, 2022

Closes #231

@techprimate-bot
Copy link

techprimate-bot commented Dec 17, 2022

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning PDFGeneratorImageDelegate.swift:16 public declarations should be documented. (missing_docs)
Warning PDFGeneratorImageDelegate.swift:16 Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)
Warning PDFGenerator.swift:65 Lines should not have trailing whitespace. (trailing_whitespace)
Warning PDFGenerator.swift:67 Delegates should be weak to avoid reference cycles. (weak_delegate)
Warning PDFAttributedText.swift:65 override modifier should be before public. (modifier_order)
Warning PDFAttributedText.swift:64 Lines should not have trailing whitespace. (trailing_whitespace)
Warning PDFSimpleText.swift:83 Lines should not have trailing whitespace. (trailing_whitespace)
Warning PDFText.swift:15 Files should have a single trailing newline. (trailing_newline)
Warning PDFGenerator+Generation.swift:195 Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)
Warning PDFGenerator+Generation.swift:195 Line should be 150 characters or less: currently 172 characters (line_length)

Generated by 🚫 Danger Swift against 9786cbf

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Patch coverage: 16.66% and project coverage change: +78.86 🎉

Comparison is base (1955ebb) 0.00% compared to head (9786cbf) 78.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #319       +/-   ##
==========================================
+ Coverage   0.00%   78.86%   +78.86%     
==========================================
  Files        210      212        +2     
  Lines      12379    12608      +229     
==========================================
+ Hits           0     9943     +9943     
+ Misses     12379     2665     -9714     
Flag Coverage Δ
iOS 79.78% <16.66%> (?)
macOS 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rce/API/Delegation/PDFGeneratorImageDelegate.swift 0.00% <0.00%> (ø)
Source/API/PDFGenerator.swift 100.00% <ø> (+100.00%) ⬆️
Source/API/Text/PDFAttributedText.swift 61.90% <0.00%> (+61.90%) ⬆️
Source/API/Text/PDFSimpleText.swift 70.00% <0.00%> (+70.00%) ⬆️
Source/API/Text/PDFText.swift 0.00% <0.00%> (ø)
Source/API/PDFGenerator+Generation.swift 90.53% <66.66%> (+90.53%) ⬆️

... and 181 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brendand
Copy link
Contributor

This is interesting, but what's the use case for it? Why would you need to know when images are being drawn? Does it make for a more accurate process indicator? Mine usually goes straight to 33%, then to 66%, then to 100%. Would be nice to see more increments.

@philprime
Copy link
Member Author

@brendand I recommend reading through the discussion in #231

@philprime philprime force-pushed the issue-231-generator-delegate branch from c353bda to 61e2170 Compare May 21, 2023 09:11
@philprime philprime merged commit b5a4952 into main May 21, 2023
@philprime philprime deleted the issue-231-generator-delegate branch May 21, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watermarks for Images
4 participants