Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added edge-case handling for images with zero available height #377

Merged
merged 1 commit into from
May 15, 2024

Conversation

philprime
Copy link
Member

@philprime philprime commented May 12, 2024

Closes #366
Closes #367

@philprime philprime self-assigned this May 12, 2024
@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning ExperimentFactory.swift:6 Header comments should be consistent with project patterns. (file_header)
Warning ExperimentFactory.swift:39 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning ExperimentFactory.swift:27 Collection literals should not have trailing commas. (trailing_comma)

Generated by 🚫 Danger Swift against 0d6bfb4

@philprime philprime merged commit 5075703 into main May 15, 2024
7 checks passed
@philprime philprime deleted the issue-366 branch May 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Image to Generate PDF on iOS 17, there is crash
2 participants