Merge pull request #13 from techvalidate/blanktooltip

SOLN-11751: Blank tooltip after browser navigation
techvalidate · May 23, 2019 · 9d8801f · 9d8801f
2 parents daf672b + 7ff8d4a
commit 9d8801f
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 3 deletions.
diff --git a/pano.js b/pano.js
@@ -23645,7 +23645,10 @@ var _class = function (_Controller) {
     key: 'setContent',
     value: function setContent() {
       if (this.element.hasAttribute('title')) {
-        this.content = this.element.getAttribute('title');
+        var title = this.element.getAttribute('title');
+        this.content = title;
+        // Add back the title attribute in disconnect(), so the title is present when navigating browser hsitory.
+        this.title = title;
         this.element.removeAttribute('title');
       }
 
@@ -23729,6 +23732,15 @@ var _class = function (_Controller) {
         this.element.setAttribute('data-target', this.type + '.hover');
       }
     }
+  }, {
+    key: 'disconnect',
+    value: function disconnect() {
+      // reset the element title navigating back/forward in the browser history will show the inital title
+      var title = this.title;
+      if (this.title) {
+        this.element.setAttribute('title', title);
+      }
+    }
   }, {
     key: 'container',
     get: function get() {
@@ -23752,6 +23764,14 @@ var _class = function (_Controller) {
     get: function get() {
       return $('#' + this.id);
     }
+  }, {
+    key: 'title',
+    get: function get() {
+      return this._title;
+    },
+    set: function set(title) {
+      this._title = title;
+    }
   }]);
 
   return _class;

diff --git a/pano.js.map b/pano.js.map
diff --git a/src/controllers/tooltips/tooltipController.js b/src/controllers/tooltips/tooltipController.js
@@ -35,9 +35,20 @@ export default class extends Controller {
     return $(`#${this.id}`)
   }
 
+  get title() {
+    return this._title
+  }
+
+  set title(title) {
+    this._title = title
+  }
+
   setContent() {
     if (this.element.hasAttribute('title')) {
-      this.content = this.element.getAttribute('title')
+      const title = this.element.getAttribute('title')
+      this.content = title
+      // Add back the title attribute in disconnect(), so the title is present when navigating browser hsitory.
+      this.title = title
       this.element.removeAttribute('title')
     }
 
@@ -122,4 +133,12 @@ export default class extends Controller {
       this.element.setAttribute('data-target', `${this.type}.hover`)
     }
   }
+
+  disconnect() {
+    // reset the element title navigating back/forward in the browser history will show the inital title
+    const title = this.title
+    if (this.title) {
+      this.element.setAttribute('title', title)
+    }
+  }
 }