Add FilesystemIo to read from output dir

tectonic-typesetting · Apr 23, 2021 · c9efbd1 · c9efbd1
1 parent 1f63089
commit c9efbd1
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 8 deletions.
diff --git a/src/driver.rs b/src/driver.rs
@@ -549,6 +549,11 @@ impl ProcessingSessionBuilder {
             io.filesystem_root(fsr);
         }
 
+        // TODO do we also need to OutputDestination::Default?
+        if let OutputDestination::Path(ref p) = self.output_dest {
+            io.output_directory(p.clone());
+        }
+
         let output_path = match self.output_dest {
             OutputDestination::Default => Some(default_output_path),
             OutputDestination::Path(p) => Some(p),

diff --git a/src/io/setup.rs b/src/io/setup.rs
@@ -32,7 +32,7 @@ pub struct IoSetup {
     primary_input: Box<dyn IoProvider>,
     pub bundle: Option<Box<dyn Bundle>>,
     pub mem: MemoryIo,
-    filesystem: FilesystemIo,
+    filesystems: Vec<FilesystemIo>,
     pub format_cache: Option<FormatCache>,
     genuine_stdout: Option<GenuineStdoutIo>,
     format_primary: Option<BufferedPrimaryIo>,
@@ -48,7 +48,9 @@ impl IoSetup {
 
         providers.push(&mut *self.primary_input);
         providers.push(&mut self.mem);
-        providers.push(&mut self.filesystem);
+        for fs in self.filesystems.iter_mut() {
+            providers.push(fs);
+        }
 
         if let Some(ref mut b) = self.bundle {
             providers.push(b.as_ioprovider_mut());
@@ -123,6 +125,7 @@ pub struct IoSetupBuilder {
     bundle: Option<Box<dyn Bundle>>,
     use_genuine_stdout: bool,
     hidden_input_paths: HashSet<PathBuf>,
+    output_directory: Option<PathBuf>,
 }
 
 impl Default for IoSetupBuilder {
@@ -134,6 +137,7 @@ impl Default for IoSetupBuilder {
             bundle: None,
             use_genuine_stdout: false,
             hidden_input_paths: HashSet::new(),
+            output_directory: None,
         }
     }
 }
@@ -212,6 +216,12 @@ impl IoSetupBuilder {
         self
     }
 
+    /// Set the output directory.
+    pub fn output_directory<P: AsRef<Path>>(&mut self, path: P) -> &mut Self {
+        self.output_directory = Some(path.as_ref().to_owned());
+        self
+    }
+
     /// Creates an `IoSetup`.
     ///
     /// # Panics
@@ -240,15 +250,28 @@ impl IoSetupBuilder {
             }
         };
 
+        let mut filesystems = vec![FilesystemIo::new(
+            &self.filesystem_root,
+            false,
+            true,
+            self.hidden_input_paths.clone(),
+        )];
+
+        // We want to also allow reading from the output directory. This is to support e.g.
+        // shell-escape, which writes its outputs to this directory (rather than filesystem_root).
+        if let Some(output_directory) = self.output_directory.as_ref() {
+            filesystems.push(FilesystemIo::new(
+                output_directory,
+                false,
+                false,
+                self.hidden_input_paths,
+            ));
+        }
+
         Ok(IoSetup {
             primary_input: pio,
             mem: MemoryIo::new(true),
-            filesystem: FilesystemIo::new(
-                &self.filesystem_root,
-                false,
-                true,
-                self.hidden_input_paths,
-            ),
+            filesystems,
             format_cache,
             bundle: self.bundle,
             genuine_stdout: if self.use_genuine_stdout {