Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch more bibtex tests #1039

Merged
merged 3 commits into from
May 22, 2023

Conversation

CraftSpider
Copy link
Contributor

This includes tests for crossrefs, multiple cites, and some bad aux lines. This should cover most of the important main code paths as well as some particularly useful warning/error paths.

…nes. This should cover most main code paths as well as some particularly useful warning/error paths
@CraftSpider
Copy link
Contributor Author

CraftSpider commented May 19, 2023

These tests aren't just for my bibtex rewriting work - this batch catches another real error due to cite_xptr never getting set to 0 on init, which I suspected when I noticed it in rewrite, but running these tests confirms it, as it causes run-order dependent failures.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1039 (84604ac) into master (b8b0245) will increase coverage by 0.25%.
The diff coverage is n/a.

❗ Current head 84604ac differs from pull request most recent head acb9744. Consider uploading reports for the commit acb9744 to get more accurate results

@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   44.84%   45.09%   +0.25%     
==========================================
  Files         155      155              
  Lines       62605    62609       +4     
==========================================
+ Hits        28074    28234     +160     
+ Misses      34531    34375     -156     
Impacted Files Coverage Δ
crates/engine_bibtex/bibtex/bibtex.c 50.67% <ø> (+5.91%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CraftSpider
Copy link
Contributor Author

Error appears to be that on Linux, whatever opening a directory returns, it doesn't cause issues - but on Windows, you get PermissionDenied, which means it returns an error instead of trying with the extension. I'm just gonna move that test out of the directory for now, since it's a one-off anyways.

@pkgw
Copy link
Collaborator

pkgw commented May 20, 2023

Great stuff! It looks like the main CI tests passed for the most recent iteration, but GitHub is only showing me the ArXiv check. I'm going to close this and then reopen to retrigger the CI just for completeness.

@pkgw pkgw closed this May 20, 2023
@pkgw pkgw reopened this May 20, 2023
@CraftSpider
Copy link
Contributor Author

Yeah, from what I could tell, I pushed twice too close and the tests ran on the second commit but got attached to the first. Either way, looks happy now.

@pkgw pkgw merged commit 6b6df36 into tectonic-typesetting:master May 22, 2023
@CraftSpider CraftSpider deleted the more-bibtests branch December 1, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants