-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustify engine_bibtex - Part 4, the last of it #1083
Rustify engine_bibtex - Part 4, the last of it #1083
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 46.27% 46.24% -0.04%
==========================================
Files 171 171
Lines 65031 65038 +7
==========================================
- Hits 30093 30076 -17
- Misses 34938 34962 +24
... and 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
16922ab
to
c6b754b
Compare
…ntly, has a good bit of cleanup opportunities
This was accidentally rewound in 5925963, "Try improving x_substring a bit".
fe93d2c
to
0f16f26
Compare
I have taken the liberty of rebasing your current branch to the new |
Awesome, thank you. There may be a slight delay on the final commits - I got a bit ambitious, tried to do too much in one commit, and need to rollback and re-try. Frustrating, but better to accept it and start again then keep playing whack-a-mole with like 200 lifetime errors. |
@CraftSpider FYI, I'm hoping to put out a new release soon, so that people can try the new Linux aarch64 builds and Linux binaries that link against OpenSSL 3 (#1092). But it's really easy for me to roll releases with the automation we have using Cranko, so don't worry, I'll make another release promptly whenever this PR gets merged! |
…etter ownership handling
There are infinite cleanups I could do, but this should be ready and those can come later. This rips out all remaining C code, and does some basic cleanup on the resulting crate, though it's still very obviously ported code still. |
Sorry for letting this linger so long! I've been trying to pare down my GitHub backlog the past few weeks and somehow it keeps getting bigger :-/ I haven't lost track of this, though. |
Argh, very sorry for taking so long. Rather than letting this keep on sitting as I try to find the time to give it the review it deserves, at this point I'm just going to go ahead and merge. Thank you for all of your work on this project! |
This builds on #1077, converting aux and bst code. Opening to get tectonic-on-arxiv runs going, I'm slightly dubious that
get_bib_command_or_entry_and_process
is perfect yet, it's a really messed-up function.