-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 CLI: Add external commands #1103
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
==========================================
- Coverage 46.29% 46.20% -0.09%
==========================================
Files 171 171
Lines 65111 65099 -12
==========================================
- Hits 30142 30078 -64
- Misses 34969 35021 +52 ☔ View full report in Codecov by Sentry. |
Cool! I think it would be useful to add tests for each target ( Hm, I wonder if the |
Thanks! I'm going to close and reopen this to rerun the CI to check that this still builds cleanly against the latest |
Agreed that it would be good to add test coverage for this, although I admit that it might take a fair amount of work to implement for relatively small benefit. It might be helpful to see if Cargo has a clever, lightweight way for testing this kind of functionality. One further ask that's a little bit more important to me would be updating the documentation somewhere to mention this capability. I'm not sure if there's a single best place in the docs to describe it, but ideally it should be described somewhere. |
The Azure Pipelines CI failures are spurious — a side effect of me merging another PR while this one was running. They should go away with the next fresh CI build. |
Implemented the feature proposed in #737.
Is it really that easy?
A question:
Should
v2_main
exit earlier if an external command is given?We probably don't need to set up colors and customizations if we're running an external command.