Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bibtex] Fix UB caused by invalidating protected reference #1129

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

CraftSpider
Copy link
Contributor

Another option here might be to simply use the system allocator through std::alloc, at which point bibtex would actually be entirely Rust, no external links at all.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82e78d4) 46.28% compared to head (06591ac) 46.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   46.28%   46.28%           
=======================================
  Files         171      171           
  Lines       65099    65099           
=======================================
  Hits        30129    30129           
  Misses      34970    34970           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkgw pkgw merged commit c64e524 into tectonic-typesetting:master Dec 6, 2023
28 checks passed
@CraftSpider CraftSpider deleted the fix-bib-ub branch February 21, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants