Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various small issues in driver module. #184

Merged
merged 1 commit into from
Jun 24, 2018

Conversation

jneem
Copy link
Contributor

@jneem jneem commented Jun 24, 2018

This makes some fields public, so that it's possible to get interesting
information out of IoEvents. Also, fixes the behaviour of
ProcessingSessionBuilder::output_dir to match its documentation (i.e.,
don't panic if the output_dir is not provided).

This makes some fields public, so that it's possible to get interesting
information out of IoEvents. Also, fixes the behaviour of
ProcessingSessionBuilder::output_dir to match its documentation (i.e.,
don't panic if the output_dir is not provided).
@pkgw
Copy link
Collaborator

pkgw commented Jun 24, 2018

Looks great, will merge as soon as CI passes. Thanks!

@pkgw pkgw self-assigned this Jun 24, 2018
@codecov
Copy link

codecov bot commented Jun 24, 2018

Codecov Report

Merging #184 into master will increase coverage by 0.18%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   37.97%   38.15%   +0.18%     
==========================================
  Files         131      131              
  Lines       60830    60974     +144     
==========================================
+ Hits        23099    23264     +165     
+ Misses      37731    37710      -21
Impacted Files Coverage Δ
src/driver.rs 52.83% <78.94%> (+15.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aedad1...51ad2d3. Read the comment docs.

@pkgw pkgw merged commit 58efdb6 into tectonic-typesetting:master Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants