-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More work towards HTML output #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a paragraph containing a small PNG image. This test is all about increasing the code coverage.
Another one that's all about boosting code coverage.
Which involves introducing more macros for symbolic access to various node properties.
Hopefully this will fix the CI failure I've been seeing.
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 38.24% 39.87% +1.63%
==========================================
Files 133 133
Lines 63695 63742 +47
==========================================
+ Hits 24359 25419 +1060
+ Misses 39336 38323 -1013
Continue to review full report at Codecov.
|
Older MSVC compilers don't like %z; add some #define logic to make things portable.
29686db
to
cdc358b
Compare
For some reason this test is now giving problems on AppVeyor ... but not when I build Tectonic myself. Everything else works and this test isn't "special", so just disable it for expediency. Bug tectonic-typesetting#244 filed to track this hack, though.
Mrmaxmeier
pushed a commit
to Mrmaxmeier/tectonic
that referenced
this pull request
Dec 13, 2019
Merge xetex_layout_engine and xetex_layout_interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which, in practice, means tedious analysis of the
line_break()
function, because I am (slowly) working towards giving it a mode where it basically doesn't do any linebreaking.I've added a few tests that should hopefully juice the coverage; they at least do add some coverage within
line_break()
.