Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo update #355

Merged
merged 1 commit into from
Mar 27, 2019
Merged

cargo update #355

merged 1 commit into from
Mar 27, 2019

Conversation

spl
Copy link
Contributor

@spl spl commented Mar 26, 2019

There are some updates that showed up in #330, but they're not relevant to that change. I guess that happened when I changed the dependencies. So I'd suggest merging this first.

Updating cfg-if v0.1.6 -> v0.1.7
Updating crc32fast v1.1.2 -> v1.2.0
Updating openssl v0.10.19 -> v0.10.20
Updating openssl-sys v0.9.42 -> v0.9.43
Updating rand_os v0.1.2 -> v0.1.3
Updating syn v0.15.27 -> v0.15.29

@pkgw
Copy link
Collaborator

pkgw commented Mar 26, 2019

Thanks! If you haven't seen, we do use Dependabot, so in principle we should get automated updates of dependencies with independent PRs to check for CI problems. But it's also true that sometimes Dependabot seems not to bump certain deps even though a manual cargo update will bring them up.

@pkgw pkgw self-assigned this Mar 26, 2019
Updating cfg-if v0.1.6 -> v0.1.7
Updating crc32fast v1.1.2 -> v1.2.0
Updating openssl v0.10.19 -> v0.10.20
Updating openssl-sys v0.9.42 -> v0.9.43
Updating rand_os v0.1.2 -> v0.1.3
Updating syn v0.15.27 -> v0.15.29
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   39.61%   39.61%           
=======================================
  Files         135      135           
  Lines       59496    59496           
=======================================
  Hits        23569    23569           
  Misses      35927    35927

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2164686...e253bc3. Read the comment docs.

@spl
Copy link
Contributor Author

spl commented Mar 26, 2019

Thanks. I was aware of the use of Dependabot, though I don't know how it's configured. Some of these deps were updated when I was working on #330, which was over a week ago, and Dependabot hasn't PR'd anything about them. I'm not sure how it decides when to PR or when not to.

Seems like there was an osx issue on Travis-CI. I just rebased to master to see if that will fix it.

@spl
Copy link
Contributor Author

spl commented Mar 27, 2019

It now passes CI.

@pkgw Just to be clear, would you prefer individual PRs with each dependency changed? I have no problem with that, though it is quite a bit more work.

While investigating Dependabot myself for the first time, I tried the “Bump now” button for my fork of the tectonic repository. It took a while, but it did produce PRs of a large number of dependency bumps, including the ones I bumped here.

If you prefer Dependabot to do the work, you might try the “Bump now” button.

@pkgw
Copy link
Collaborator

pkgw commented Mar 27, 2019

@spl Nah, if a human's doing it, separating out each dep is overkill.

@pkgw pkgw merged commit e186cbb into tectonic-typesetting:master Mar 27, 2019
@spl spl deleted the cargo-update branch March 27, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants