Repair the archive.org URL resolution #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=======================================
Coverage 47.08% 47.08%
=======================================
Files 146 146
Lines 59489 59500 +11
=======================================
+ Hits 28009 28016 +7
- Misses 31480 31484 +4
Continue to review full report at Codecov.
|
The archive.org PURL service made a recent change that broke our URL resolution algorithm. The new redirect structure is: ``` https://archive.org/services/purl/net/pkgwpub/tectonic-default -> 307 Temporary redirect https://purl.prod.archive.org/net/pkgwpub/tectonic-default -> 302 Found https://ttassets.z13.web.core.windows.net/tlextras-2020.0r0.tar -> 200 OK ``` The problem is that we stop chasing redirects if the final path component of the new URL doesn't contain a `.`, in an attempt to not scan into things like S3 storage URLs. But this means that we stop at the first URL, which is wrong. To fix this, we semi-hack the logic to also follow the redirection if the filename of the new URL matches the filename of the original URL.
This was surfaced by the recent archive.org issue, but doesn't actually have anything to do with the proper solution of the issue. But while we're at it, the 302 and 307 status codes are nearly semantically equivalent, so if we accept 302 we should accept 307. Note that this fix would have masked the archive.org issue ... things would have worked but our URL resolution would have been giving improper results.
rikhuijzer
approved these changes
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix our ability to resolve the default bundle.
CC #765, #831