update: Update MAX_STRINGS value #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set the value of MAX_STRINGS to 15000. It turns out 10000 was not enough to cleanly build the example mentioned in tectonic-typesetting#81 using (https://github.com/cryptobib/export_crossref/blob/118d812c4e1e8c462d3b1f226c02b9b1c6e4b505/abbrev0.bib). * Fixes tectonic-typesetting#79 Signed-off-by: mr.Shu <mr@shu.io>
|
@pkgw I am not sure if this is the correct way of fixing this, but it seems that the aforementioned file is actually an edge case (with regards to the number of entries). The code in this PR was able to generate a PDF from the example mentioned in #81. Please feel free to point me to a better way of dealing with this. Thanks! |
|
@mrshu If you've gone to the work to get the test case to work, I think what you've done must be exactly right! Thanks for the contribution. I'm trying to get discussions of the more user-facing side of Tectonic going at its new forum site; please sign up if you're interested! |
|
Thanks for the invitation @pkgw, will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the value of MAX_STRINGS to 15000. It turns out 10000 was not
enough to cleanly build the example mentioned in Something bad happened inside BibTeX: you've exceeded BibTeX's number of strings 4000 #81 using
(https://github.com/cryptobib/export_crossref/blob/118d812c4e1e8c462d3b1f226c02b9b1c6e4b505/abbrev0.bib).
Fixes Handling large bib files #79
Signed-off-by: mr.Shu mr@shu.io