We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a bug in sorting query string parameters in case when parameter keys include dashes
https://github.com/sam-washington/requests-aws4auth/blob/master/requests_aws4auth/aws4auth.py#L661
Here parameters are sorted after they urlencoded, which puts them in a wrong order.
For example:
sorted("id=1000000161418039&id-type=receipt".split("&")) >>> ['id-type=receipt', 'id=1000000161418039']
If you sort them by name, as AWS describes here http://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html, the order would be the following
sorted([tuple(pair.split("=")) for pair in "id=1000000161418039&id-type=receipt".split("&")], key=lambda x: x[0]) >>> [('id', '1000000161418039'), ('id-type', 'receipt')]
The text was updated successfully, but these errors were encountered:
merged.
Sorry, something went wrong.
add tests for #21 #49
91d17d8
No branches or pull requests
There is a bug in sorting query string parameters in case when parameter keys include dashes
https://github.com/sam-washington/requests-aws4auth/blob/master/requests_aws4auth/aws4auth.py#L661
Here parameters are sorted after they urlencoded, which puts them in a wrong order.
For example:
If you sort them by name, as AWS describes here http://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html, the order would be the following
The text was updated successfully, but these errors were encountered: