Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add square brackets to primary keys #1394

Merged
merged 1 commit into from
May 11, 2022
Merged

Add square brackets to primary keys #1394

merged 1 commit into from
May 11, 2022

Conversation

colgatto
Copy link
Contributor

@colgatto colgatto commented May 11, 2022 •
edited by dhensby
Loading

Added square brackets to primary keys when creating the table.
This prevents errors when using special characters in the column name.

  • Update change log

@dhensby dhensby changed the base branch from master to 7 May 11, 2022 14:12
dhensby
dhensby approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I've rebased this to target 7 so we can get the fix into the 7.x and 8.x lines (I'll sort that out once merged).

@dhensby dhensby merged commit 5b06217 into tediousjs:7 May 11, 2022
@colgatto colgatto deleted the fix_missing_square branch May 13, 2022 10:11
@dhensby
Copy link
Collaborator

dhensby commented May 18, 2022

Released in 8.1.1 and 7.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhensby dhensby dhensby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colgatto @dhensby