Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requestTimeout option #1398

Merged
merged 3 commits into from
Aug 8, 2022
Merged

fix: requestTimeout option #1398

merged 3 commits into from
Aug 8, 2022

Conversation

PopGoesTheWza
Copy link
Contributor

@PopGoesTheWza PopGoesTheWza commented May 29, 2022

What this does:

The requestTimeout options is not properly handled/accounted for.

Related issues:

#1396

Pre/Post merge checklist:

  • Update change log

@thegoatherder
Copy link

@PopGoesTheWza is there any update on this? I'm experiencing the same issue. Is there any workaround I can use when using the connection string? I'm importing the string from an XML profile in an SSDT project - so not using the connection string isn't really an option for me.

@PopGoesTheWza
Copy link
Contributor Author

@thegoatherder for now, I simply patch the relevant .js from the node_modules. Dirty and kludgy.

@thegoatherder
Copy link

@thegoatherder for now, I simply patch the relevant .js from the node_modules. Dirty and kludgy.

Kludgy indeed! Will do that for now, hope this PR gets approved soon!

@dhensby dhensby merged commit aeba05e into tediousjs:master Aug 8, 2022
@dhensby
Copy link
Collaborator

dhensby commented Aug 8, 2022

Thanks for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants