Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(msnodesqlv8/request): remove superfluous arg #1408

Merged
merged 1 commit into from
Aug 8, 2022
Merged

chore(msnodesqlv8/request): remove superfluous arg #1408

merged 1 commit into from
Aug 8, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Jul 12, 2022

What this does:

Removes superfluous arg from castParameter() call.
It only accepts two args:

const castParameter = function (value, type) {

Related issues:

N/A

Pre/Post merge checklist:

  • Update change log

@Fdawgs
Copy link
Contributor Author

Fdawgs commented Aug 8, 2022

@dhensby mind taking a gander when you have a second, please?

Copy link
Collaborator

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@dhensby dhensby merged commit e783859 into tediousjs:master Aug 8, 2022
@Fdawgs Fdawgs deleted the patch-1 branch August 8, 2022 08:48
@dhensby
Copy link
Collaborator

dhensby commented Aug 8, 2022

Sorry for the delay, I had seen this and did some investigation to check it was all ok but just forgot to merge it!

@Fdawgs
Copy link
Contributor Author

Fdawgs commented Aug 8, 2022

Sorry for the delay, I had seen this and did some investigation to check it was all ok but just forgot to merge it!

Thanks, no need to apologise, we're all busy! Thanks for maintaining this and other repos my hospital uses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants