Fix README to document requirement for TCP/IP to be enabled in SQL Server #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjosh
changed the title
|
Thanks for this. I'm worried that these docs are much too specific for people installing and using a GUI/SQL server configuration manager. I think all that is required is a comment that TCP/IP is required to be enabled on the SQL instance. This isn't docs for managing SQL servers (it's just a client) and this becomes maintenance overhead as the GUI/process changes. If there are official MS docs to link to, I'm happy with that, but not to link to unaffiliated 3rd parties. PS same feedback as last PR regarding commit message 🙏 |
dhensby
force-pushed
the
document-tcpip-requirement
branch
from
d5f76e6
to
2549c31
Compare
|
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
Documents the requirement for TCP/IP to be enabled and provides instructions for enabling it
Related issues:
#574
#1649
Pre/Post merge checklist: