refactor: convert ConnectionError and RequestError to proper classes

BREAKING CHANGE: Constructing a `ConnectionError` or `RequestError` now requires to using the `new` keyword.
tediousjs · Oct 8, 2021 · 3e489b4 · 3e489b4
1 parent ca8afd3
commit 3e489b4
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 111 deletions.
diff --git a/src/errors.d.ts b/src/errors.d.ts
diff --git a/src/errors.js b/src/errors.js
diff --git a/src/errors.ts b/src/errors.ts
@@ -0,0 +1,28 @@
+export class ConnectionError extends Error {
+  code: string | undefined;
+
+  isTransient: boolean | undefined;
+
+  constructor(message: string, code?: string) {
+    super(message);
+
+    this.code = code;
+  }
+}
+
+export class RequestError extends Error {
+  code: string | undefined;
+
+  number: number | undefined;
+  state: number | undefined;
+  class: number | undefined;
+  serverName: string | undefined;
+  procName: string | undefined;
+  lineNumber: number | undefined;
+
+  constructor(message: string, code?: string) {
+    super(message);
+
+    this.code = code;
+  }
+}
diff --git a/test/integration/connection-test.js b/test/integration/connection-test.js
@@ -1354,7 +1354,7 @@ describe('Advanced Input Test', function() {
     const config = getConfig();
     config.options.enableAnsiNullDefault = false;
 
-    runSqlBatch(done, config, sql, function(/** @type {RequestError | null | undefined} */err) {
+    runSqlBatch(done, config, sql, function(/** @type {Error | null | undefined} */err) {
       assert.instanceOf(err, RequestError);
       assert.strictEqual(/** @type {RequestError} */(err).number, 515);
     }); // Cannot insert the value NULL