refactor!: cleanup AbortSignal handling
#1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurschreiber
force-pushed
the
arthur/signal-cleanups
branch
from
841cceb
to
1d56dbf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
+ Coverage 78.25% 79.13% +0.88%
==========================================
Files 93 90 -3
Lines 4879 4855 -24
Branches 937 929 -8
==========================================
+ Hits 3818 3842 +24
+ Misses 762 710 -52
- Partials 299 303 +4 ☔ View full report in Codecov by Sentry. |
|
One note from discussing this with @MichaelSun90 - this probably requires bumping the EDIT: And this makes it a breaking change, so we need to thing about that too. |
arthurschreiber
changed the title
AbortSignal handlingAbortSignal handling
|
🎉 This PR is included in version 19.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
tediousnow requires Node.js version 18.17 or later.