Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify connection establishment #1663

Merged
merged 14 commits into from
Sep 15, 2024

Conversation

arthurschreiber
Copy link
Collaborator

  • Instead of calling this.socketError, throw errors and have them handled centrally in initialiseConnection.
  • Use async/await wherever possible.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 76.05634% with 51 lines in your changes missing coverage. Please review.

Project coverage is 86.09%. Comparing base (e1b37fb) to head (8fc86dc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/connection.ts 76.05% 49 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
+ Coverage   85.47%   86.09%   +0.62%     
==========================================
  Files          90       90              
  Lines        4859     4853       -6     
  Branches      924      920       -4     
==========================================
+ Hits         4153     4178      +25     
+ Misses        702      670      -32     
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber arthurschreiber force-pushed the arthur/refactor-states-for-connecting branch from 7d6d9a3 to 2e4cf8b Compare September 12, 2024 15:54
@arthurschreiber arthurschreiber force-pushed the arthur/refactor-states-for-connecting branch from 6c1232c to 96a9ac4 Compare September 15, 2024 08:57
@arthurschreiber arthurschreiber force-pushed the arthur/refactor-states-for-connecting branch from 96a9ac4 to 8fc86dc Compare September 15, 2024 09:21
@arthurschreiber arthurschreiber merged commit c2db7fb into master Sep 15, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant