fix money validate range

[heroboy]

fix #812

[Hadis-Knj]

Would be ✨ if you write a test for it too

[Hadis-Knj]

@heroboy thanks for preparing this PR, it looks good to me, would you also please fix the linter issues, you can run npm run lint to get the log of the issues

[heroboy]

@Hadis-Fard any update on this? What I need to do more?

[arthurschreiber]

@heroboy Thanks for this fix! I'll try and get it merged asap! 🙇

[arthurschreiber]

This would be simpler. I think this.writeInt32LE is already doing the | 0 operation internally. 👍

Suggested change

	this.writeInt32LE((value * SHIFT_RIGHT_32) | 0);
	this.writeInt32LE(value * SHIFT_RIGHT_32);

[heroboy]

I don't think so. For example: buf.writeInt32LE((0x7fffffff)+0.5) doesn't work. The |0 is to ensure the parameter is an int. And without this, it doesn't pass my money-type-test.

[heroboy]

hi @arthurschreiber @Hadis-Fard
I rewrite the writeMoney function, because my original version is not correct to write negative value. For example, if value is -100:

this.writeInt32LE(Math.floor(value * SHIFT_RIGHT_32)); // write -1, correct
this.writeInt32LE((value * SHIFT_RIGHT_32) | 0);//write 0, not correct

I add some integration test to test these. Hope this works.

[heroboy]

any update on this? If my pr is not good, I don't mind you making yours.
I just want to fix this.

[IanChokS]

@heroboy Looks like your branch is a bit out of date. Do you mind updating it, resolving the conflict and we can try to move forward with this? Thanks!

[codecov]

Codecov Report

Merging #815 into master will decrease coverage by 1.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   80.77%   79.51%   -1.26%     
==========================================
  Files          86       86              
  Lines        4384     4403      +19     
  Branches      793      794       +1     
==========================================
- Hits         3541     3501      -40     
- Misses        584      644      +60     
+ Partials      259      258       -1     

Impacted Files	Coverage Δ
src/data-types/money.ts	92.30% <0.00%> (-7.70%)	⬇️
src/tracking-buffer/writable-tracking-buffer.ts	64.45% <0.00%> (-7.36%)	⬇️
src/incoming-message-stream.ts	92.30% <0.00%> (-5.13%)	⬇️
src/connection.ts	60.68% <0.00%> (-3.63%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb901a...3d8cccd. Read the comment docs.

[heroboy]

Fix all. but I don't know how to fix the commit lint.

[IanChokS]

@heroboy Thanks for updating this PR! I'm not sure how to fix the lint issues as well, but I'll ping @arthurschreiber for him to take a look at this. 🙇