Add ginkgomon_v2 to support Ginkgo v2+ #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let me know if you need me to make any changes @tedsuo also it looks like i have commit rights - i'd be happy to merge the PR in (and deal with any resulting issues - though I don't anticipate any) |
|
Ah sorry! This looks good, merging. :) |
|
thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tedsuo - here's the change to support Ginkgo v2+
As you can see it's pretty trivial and copy-pastad my way there. I validated everything works locally with 2.0 but didn't touch anything else in Ifrit. Upgrading to Ginkgo 2.0 for Ifrit itself would entail adopting go modules and doing some (fairly minor) tweaks - it's not necessary, this PR should unblock ifrit's consumers.
/cc onsi/ginkgo#875