Initial commit #2
Conversation
| ``` | ||
| $ git clone https://github.com/tee-ar-ex/trx-javascript | ||
| $ cd trx-javascript | ||
| $ npm install gl-matrix fflate fzstd |
There was a problem hiding this comment.
Is it possible to write what is the correct version of Node?
I used sudo apt and the version was so old the code kept crashing on the first line.
When I installed it directly from a .tar.gz from their website it worked immediately.
Something like?
Install the appropriate version of the most recent [NodeJS](https://nodejs.org/en/download/).
There was a problem hiding this comment.
@neurolabusc : do you want to address this question in this PR, or should we merge and add this as an issue for future work?
|
@frheault one nice thing about Debian releases is they freeze software to make user experience consistent. This can also be frustrating when the user wants new features. I have updated the readme as you suggested. Note that node is only required for using the javascript from the command line. The code is compatible with all modern web browsers, as demonstrated by the NiiVue live demo. |
|
@frheault I do think the revised PR addresses your concerns. If you agree, can you accept and apply this pull request. |
There was a problem hiding this comment.
A couple of small documentation suggestions/fixes from my end. How was the example file generated? Would it make sense to also put it on figshare? See also discussions surrounding tee-ar-ex/trx-python#32
|
@arokem I am happy with all your changes. Feel free to apply them and submit this initial PR. I do plan to make testing datasets available, but was waiting for a decision on the final format. My reader will work fine with or without the proposed modification, but I want the exemplar data to reflect the finalized format. |
No description provided.