Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer: add support for codespan #14

Merged
merged 1 commit into from
May 26, 2022

Conversation

radeksimko
Copy link
Contributor

@radeksimko radeksimko commented May 7, 2022

Closes #11

Test cases reflect https://spec.commonmark.org/0.30/#code-spans

The two commented out test cases will panic until/unless the relevant two kinds are implemented or yuin/goldmark#299 is merged.

@radeksimko radeksimko marked this pull request as ready for review May 7, 2022 21:35
Copy link
Owner

@teekennedy teekennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One step closer to full Markdown support.

Re: the commented out test cases. I have some WIP code that should prevent the panic issue regardless of node kinds.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2287634712

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 99.677%

Totals Coverage Status
Change from base Build 2211251460: 0.02%
Covered Lines: 309
Relevant Lines: 310

💛 - Coveralls

@teekennedy teekennedy merged commit 7819c0a into teekennedy:main May 26, 2022
@radeksimko radeksimko deleted the f-codespan-support branch May 27, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rendering Code Span elements
3 participants