Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a shorter time for podman stop #2480

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Use a shorter time for podman stop #2480

merged 1 commit into from
Dec 4, 2023

Conversation

lukaszachy
Copy link
Collaborator

Those are containers to be thrown away, lets stop them much faster. Option isn't configurable.

Pull Request Checklist

  • implement the feature

@lukaszachy
Copy link
Collaborator Author

Making it draft as it doesn't seem to improve the situation as much as I hoped. I need to investigate more.

@lukaszachy lukaszachy added the step | provision Stuff related to the provision step label Nov 14, 2023
@psss
Copy link
Collaborator

psss commented Nov 29, 2023

Just tried this and it works nicely, 9 seconds of waiting saved. Have you encountered some other problem? Shall we include this in 1.30?

tmt/steps/provision/podman.py Outdated Show resolved Hide resolved
@lukaszachy lukaszachy marked this pull request as ready for review December 4, 2023 09:42
@lukaszachy
Copy link
Collaborator Author

Just tried this and it works nicely, 9 seconds of waiting saved. Have you encountered some other problem? Shall we include this in 1.30?

@psss rebased and proposed to 1.30

@lukaszachy lukaszachy added this to the 1.30 milestone Dec 4, 2023
Those are containers to be thrown away, lets stop them much faster.
@lukaszachy
Copy link
Collaborator Author

Fixed valid mypy complains....

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speed-up! Works nicely for me.

@psss psss self-assigned this Dec 4, 2023
@psss
Copy link
Collaborator

psss commented Dec 4, 2023

/packit test --identifier full

@psss psss changed the title Shorter time for podman stop Use a shorter time for podman stop Dec 4, 2023
@psss psss merged commit 45cafe6 into main Dec 4, 2023
21 checks passed
@psss psss deleted the podman-stop-timeout branch December 4, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
step | provision Stuff related to the provision step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants