Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover tmt.cli with pyright #2520

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Cover tmt.cli with pyright #2520

merged 1 commit into from
Nov 28, 2023

Conversation

happz
Copy link
Collaborator

@happz happz commented Nov 28, 2023

Pull Request Checklist

  • implement the feature

@happz happz added code | type annotations Related to type annotations and type cleanup test coverage Improvements or additions to test coverage of tmt itself labels Nov 28, 2023
@happz happz added this to the 1.31 milestone Nov 28, 2023
@happz happz modified the milestones: 1.31, 1.30 Nov 28, 2023
@happz happz mentioned this pull request Nov 28, 2023
Open
psss
psss approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@psss psss merged commit 653e0e4 into main Nov 28, 2023
16 checks passed
@psss psss deleted the pyright-cli branch November 28, 2023 11:45
@psss psss changed the title Cover tmt.cli with pyright Cover tmt.cli with pyright Nov 28, 2023
@psss psss self-assigned this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
code | type annotations Related to type annotations and type cleanup test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
2 participants
@happz @psss