Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support URL as post-install-script for artemis plugin #2628

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Support URL as post-install-script for artemis plugin #2628

merged 3 commits into from
Feb 12, 2024

Conversation

skycastlelily
Copy link
Collaborator

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz happz added step | provision Stuff related to the provision step plugin | artemis Related to Artemis provision plugin labels Jan 22, 2024
@happz
Copy link
Collaborator

happz commented Jan 22, 2024

One suggestion so far, I'd recommend changing the $SUBJ. The patch does not add the feature, the post-install script was already supported, even for OpenStack provisioning. What it adds is support for the post-install script being a URL, i.e. the plugin would download it first, then it would be passed down to Artemis. And that is also not something specific for OpenStack, it would have benefits for AWS or Beaker provisioning as well.

@skycastlelily skycastlelily force-pushed the post-script branch 2 times, most recently from 8b0bc6d to dacda9d Compare January 22, 2024 13:49
@happz happz added this to the 1.32 milestone Jan 26, 2024
lukaszachy
lukaszachy requested changes Feb 5, 2024
View reviewed changes
tmt/steps/provision/artemis.py Outdated Show resolved Hide resolved
tmt/steps/provision/artemis.py Outdated Show resolved Hide resolved
lukaszachy
lukaszachy requested changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, could you edit the the --help message as well? Currently it is not mentioned that SCRIPT can be remote location

--post-install-script SCRIPT If set, this script will be executed on the 
      guest after provisioning.

tmt/steps/provision/artemis.py Outdated Show resolved Hide resolved
lukaszachy
lukaszachy approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@happz
Copy link
Collaborator

happz commented Feb 12, 2024

/packit build

@happz
Copy link
Collaborator

happz commented Feb 12, 2024

/packit test

@happz happz merged commit 69b3cda into teemtee:main Feb 12, 2024
19 checks passed
@psss psss changed the title Handle post-install-script for provisioning openstack instance Support URL as post-install-script for artemis plugin Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

Assignees
No one assigned
Labels
plugin | artemis Related to Artemis provision plugin step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@skycastlelily @happz @lukaszachy