Drop two no longer used methods from prepare step #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
the
code | no functional change
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
|
/packit test |
|
Hm, EDIT: Thanks for #2674 |
My guess is there was a change in some package, like kernel or something similar, and slowly over time, it spread into older Fedoras. |
happz
force-pushed
the
drop-unused-methods
branch
from
39932b3
to
7769db0
Compare
lukaszachy
approved these changes
Feb 12, 2024
`_prepare_roles` and `_prepare_hosts` were used in the past, before parallelization was introduced.
psss
force-pushed
the
drop-unused-methods
branch
from
7769db0
to
908df2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_prepare_rolesand_prepare_hostswere used in the past, before parallelization was introduced.Pull Request Checklist