Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the full test execution using a label #2683

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Enable the full test execution using a label #2683

merged 2 commits into from
Feb 13, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Feb 12, 2024

Instead of having to repeatedly trigger full test suite using the /packit test commands, let's use the newly implemented require condition to enable all advanced test jobs by applying the label.

Pull Request Checklist

  • write the documentation
  • extend the test coverage

Instead of having to repeatedly trigger full test suite using the
`/packit test` commands, let's use the newly implemented `require`
condition to enable all advanced test jobs by applying the label.
@psss psss added the test coverage Improvements or additions to test coverage of tmt itself label Feb 12, 2024
@psss psss added this to the 1.32 milestone Feb 12, 2024
@psss
Copy link
Collaborator Author

psss commented Feb 12, 2024

@lukaszachy
Copy link
Collaborator

@psss Could you fix docs (e.g. add label X to run full test suite...).

Is the manual_trigger: true still true for this patch? None of such lines was deleted, just the 'require' config was added

@psss
Copy link
Collaborator Author

psss commented Feb 12, 2024

@psss Could you fix docs (e.g. add label X to run full test suite...).

Good point! Will add something.

Is the manual_trigger: true still true for this patch? None of such lines was deleted, just the 'require' config was added

Right, manual_trigger should not be needed any more. Let's get rid of it!

@psss psss added the status | blocked The merging of PR is blocked on some other issue label Feb 12, 2024
@psss
Copy link
Collaborator Author

psss commented Feb 12, 2024

There's a missing part on the packit side, marking as blocked.

@psss
Copy link
Collaborator Author

psss commented Feb 12, 2024

/packit test

@psss psss added the ci | full test Pull request is ready for the full test execution label Feb 12, 2024
@psss
Copy link
Collaborator Author

psss commented Feb 12, 2024

/packit test

@psss psss removed the status | blocked The merging of PR is blocked on some other issue label Feb 12, 2024
@psss psss self-assigned this Feb 13, 2024
@psss psss merged commit 04b752c into main Feb 13, 2024
19 checks passed
@psss psss deleted the full-test-label branch February 13, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants