Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checks smarter about environments in which they should not run #2686

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Feb 14, 2024

There are some conditions in which checks would not succeed, or turn into no-op. Adding basic "capabilities" (man 7 capabilities, man 2 syslog) which checks can then inspect.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage

@happz happz added command | tests tmt tests command check labels Feb 14, 2024
@happz happz added this to the 1.32 milestone Feb 14, 2024
@psss psss changed the title Make checks smrter about environments in which they should not run Make checks smarter about environments in which they should not run Feb 15, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@psss psss added the ci | full test Pull request is ready for the full test execution label Feb 15, 2024
There are some conditions in which checks would not succeed, or turn
into no-op. Adding basic "capabilities" (`man 7 capabilities`, `man 2
syslog`) which checks can then inspect.
@psss psss self-assigned this Feb 16, 2024
@psss psss merged commit b7d75ce into main Feb 16, 2024
22 checks passed
@psss psss deleted the checks-skip-somewhere branch February 16, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check ci | full test Pull request is ready for the full test execution command | tests tmt tests command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants