Increase the default test duration a bit
#2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psss
requested review from
lukaszachy,
happz,
thrix and
janhavlin
as code owners
psss
added
tmt tests
happz
approved these changes
Mar 21, 2024
lukaszachy
approved these changes
Mar 21, 2024
There's a bunch of tests which are executed under the `virtual` provision plan which can take a little bit more time. I suggest to increase the default `duration` as I'm not sure it's really worth to fine tune the value individually and `10m` sounds reasonable. I believe we don't have to be that strict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of tests which are executed under the
virtualprovision plan which can take a little bit more time. I suggest to increase the defaultdurationas I'm not sure it's really worth to fine tune the value individually and10msounds reasonable. I believe we don't have to be that strict.