Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept and apply workdir-root in testcloud #2838

Closed
wants to merge 5 commits into from
Closed

Accept and apply workdir-root in testcloud #2838

wants to merge 5 commits into from

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Apr 9, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily skycastlelily mentioned this pull request Apr 9, 2024
Open
@martinhoyer martinhoyer added this to the 1.41 milestone Dec 13, 2024
@martinhoyer martinhoyer added the priority | should medium priority, should be included in the next release label Dec 13, 2024
@seberm seberm added the plugin | testcloud The testcloud virtual provision plugin label Dec 13, 2024
@skycastlelily skycastlelily changed the base branch from main to workroot-images December 15, 2024 15:24
@skycastlelily skycastlelily changed the title Accept and apply workdir-root cli option in testcloud plugin Accept and apply workdir-root in testcloud Dec 15, 2024
skycastlelily added a commit to skycastlelily/tmt that referenced this pull request Dec 15, 2024
@skycastlelily
Accept and apply workdir-root in testcloud (teemtee#2838)
4f8ffd1
skycastlelily added a commit to skycastlelily/tmt that referenced this pull request Dec 15, 2024
@skycastlelily
Accept and apply workdir-root in testcloud (teemtee#2838)
96de078
@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Dec 17, 2024
@skycastlelily skycastlelily mentioned this pull request Dec 17, 2024
Merged
8 tasks
skycastlelily added a commit to skycastlelily/tmt that referenced this pull request Jan 10, 2025
@skycastlelily
Accept and apply workdir-root in testcloud (teemtee#2838)
3b374e6
@happz happz removed this from the 1.41 milestone Jan 13, 2025
@happz happz added this to the 1.42 milestone Jan 13, 2025
thrix
thrix approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix thrix added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 27, 2025
@thrix thrix modified the milestones: 1.42, 1.43 Jan 28, 2025
@thrix
Copy link
Collaborator

thrix commented Jan 28, 2025

We moved #3426 to 1.43, this also needs to be moved. @skycastlelily sorry not making it, can you add some test coverage so we can merge it into 1.43?

@lukaszachy lukaszachy removed the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Feb 4, 2025
@skycastlelily
Copy link
Collaborator Author

skycastlelily commented Feb 11, 2025 •
edited
Loading

We moved #3426 to 1.43, this also needs to be moved. @skycastlelily sorry not making it, can you add some test coverage so we can merge it into 1.43?

Sorry for the late reply, I was on two-weeks Spring Festival vacation,and never mind. By "can you add some test coverage" ,you mean for #3426,right?

@skycastlelily skycastlelily force-pushed the workroot-images branch 2 times, most recently from cfd49ea to 2e31328 Compare February 12, 2025 08:09
@happz
Copy link
Collaborator

happz commented Feb 13, 2025

@skycastlelily please, rebase when you get a chance. Conflicts should be caused by ruff format addition, it should be safe to pick your change in all conflicts, and then run pre-commit to let ruff sort out formatting.

@skycastlelily
Copy link
Collaborator Author

@skycastlelily please, rebase when you get a chance. Conflicts should be caused by ruff format addition, it should be safe to pick your change in all conflicts, and then run pre-commit to let ruff sort out formatting.

Sure,updated^^.

@happz happz deleted the branch teemtee:workroot-images February 13, 2025 22:29
@happz happz closed this Feb 13, 2025
@happz
Copy link
Collaborator

happz commented Feb 14, 2025 •
edited
Loading

Wow, I didn't mean to close this PR! I'm pretty sure I wanted to enable automerge :((

@skycastlelily any chance you might be able to push your local branch & restore this PR?

Edit: hmm, maybe I didn't close this PR. I enabled automerge in #3426, which then got merged, could it have an effect on this PR as well? :/

@skycastlelily
Copy link
Collaborator Author

Wow, I didn't mean to close this PR! I'm pretty sure I wanted to enable automerge :((

I guess so, just didn't get enough time to ping you yet,as I'm busy with reviewing:)

@skycastlelily
Copy link
Collaborator Author

And, here is the new mr: https://github.com/teemtee/tmt/pull/3526^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@thrix thrix thrix approved these changes

@frantisekz frantisekz Awaiting requested review from frantisekz

@psss psss Awaiting requested review from psss

@lukaszachy lukaszachy Awaiting requested review from lukaszachy

@janhavlin janhavlin Awaiting requested review from janhavlin

@martinhoyer martinhoyer Awaiting requested review from martinhoyer

Assignees

@skycastlelily skycastlelily

Labels
ci | full test Pull request is ready for the full test execution plugin | testcloud The testcloud virtual provision plugin priority | should medium priority, should be included in the next release
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.
6 participants
@skycastlelily @thrix @happz @seberm @lukaszachy @martinhoyer