Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path to watchdog log #2901

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix path to watchdog log #2901

merged 1 commit into from
May 31, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented May 3, 2024

It needs to be relative to step workdir, and it belongs to the directory dedicated to check logs.

Pull Request Checklist

  • implement the feature

@happz happz added bug Something isn't working check labels May 3, 2024
@happz happz added this to the 1.34 milestone May 3, 2024
@happz happz added the code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. label May 27, 2024
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label May 30, 2024
@happz
Fix path to watchdog log
ba91f4c 
It needs to be relative to step workdir, and it belongs to the directory
dedicated to check logs.
@happz happz added the ci | full test Pull request is ready for the full test execution label May 30, 2024
@happz
Copy link
Collaborator Author

happz commented May 30, 2024

/packit build

@happz happz merged commit cf64718 into main May 31, 2024
18 of 19 checks passed
@happz happz deleted the fix-watchdog-log-path branch May 31, 2024 06:53
@happz
Copy link
Collaborator Author

happz commented May 31, 2024

The /tests/discover/distgit failure seems to be unrelated, and I cannot reproduce it locally. Not blocking on this.

happz added a commit that referenced this pull request Jun 2, 2024
@happz
Fix path to watchdog log (#2901)
fb34730 
It needs to be relative to step workdir, and it belongs to the directory
dedicated to check logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@janhavlin janhavlin janhavlin approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees
No one assigned
Labels
bug Something isn't working check ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @KwisatzHaderach @janhavlin @therazix