Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DEFAULT_KEYNAME of artemis plugin #3090

Closed
wants to merge 1 commit into from
Closed

Change DEFAULT_KEYNAME of artemis plugin #3090

wants to merge 1 commit into from

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Jul 17, 2024 •
edited
Loading

To match the default key name of artemis server

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily
Copy link
Collaborator Author

skycastlelily commented Jul 17, 2024 •
edited
Loading

fix #3089, users don't have to input keyname anymore ^^

@skycastlelily
Change DEFAULT_KEYNAME of artemis plugin
09ea7a0 
To match the default key name of artemis server
@skycastlelily
Copy link
Collaborator Author

“ maybe Artemis should have some "default" key instead, which means fixing our downstream deployments and repo to avoid this name” ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz Awaiting requested review from happz happz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skycastlelily