-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running of Ansible playbooks shipped with tmt #3126
Conversation
This PR blocks #2985 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @happz's comments
It looks like this PR also fixes the #3032. |
Hm, yes and no. Yes, I think this PR might fix #3032, because the plugin and tmt will now use a better way when speaking about paths of playbooks that are shipped with tmt. But also no, because the cause is not the one mentioned in #3032, i.e. a missing fmf root - that's actually a second issue. |
marked as |
Assuming @falconizmi was not available on such late notice on Friday afternoon, I tried to address the comments above. I think there will be failed tests, I'll check them in the morning. |
Done. |
Plugins have to mangle playbook paths to appease a piece of code that expected paths to always be relative and under the fmf root. This is not true for playbooks shipped with plugins that are bundled with tmt, like `prepare/feature`. Therefore changing the code to support plugins that may never be under the fmf root.
26d311a
to
4296815
Compare
Plugins have to mangle playbook paths to appease a piece of code that
expected paths to always be relative and under the fmf root. This is not
true for playbooks shipped with plugins that are bundled with tmt, like
prepare/feature
. Therefore changing the code to support plugins thatmay never be under the fmf root.
Pull Request Checklist