Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug when prune is used along with path #3132

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix a bug when prune is used along with path #3132

merged 2 commits into from
Aug 7, 2024

Conversation

KwisatzHaderach
Copy link
Collaborator

@KwisatzHaderach KwisatzHaderach commented Aug 6, 2024 •
edited
Loading

There was a bug found when test pruning is used along with path argument in discover

Fixes #3131

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • include a release note

@KwisatzHaderach KwisatzHaderach added bug Something isn't working step | discover Stuff related to the discover step labels Aug 6, 2024
@KwisatzHaderach KwisatzHaderach added the ci | full test Pull request is ready for the full test execution label Aug 6, 2024
psss
psss requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good and I was able to reproduce and verify the issue with the original repository. But the test does not reproduce the problem. It might be related to the use of relative path in the plan.

tests/discover/prune.sh Outdated Show resolved Hide resolved
tests/discover/prune/nested.fmf Show resolved Hide resolved
psss
psss approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good. Thanks for fixing this!

@psss psss added this to the 1.35 milestone Aug 6, 2024
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 6, 2024
@psss
Copy link
Collaborator

psss commented Aug 7, 2024

The provision plan failure is irrelevant:

Couldn't fetch Fedora releases from oraculum...

Merging.

@psss psss merged commit 284a61d into main Aug 7, 2024
19 of 20 checks passed
@psss psss deleted the bug_prune_with_path branch August 7, 2024 08:04
@psss psss self-assigned this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | discover Stuff related to the discover step
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.

Test discovery fails when path is used with prune
3 participants
@KwisatzHaderach @psss @happz