-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: send() method; 'retry' parameter didn't work as specify #21
Conversation
… documentation Previously 'retry' parameter match the absolute number of resend before failing. With the fix 'retry' match the maximum number of resend a failed packet before failing
Could you guy help me in release this bug fix? |
No worries. Let me take a look. It make take a day or two. Thanks! |
Thank you Kris :) |
I approve this change, makes sense, for large data transfers we can expect some errors now and then, but they should not count against total transfer. Would be nice if we unit test, but this change is simple enough to release without if too much trouble. |
Jeff you have a fair point. |
Thank you and good luck, I suspect the unit test will be harder than the change :) |
b85b6a3
to
c1418c0
Compare
Added few unit test for the retry parameter testing the send() method. |
Looks ok, I'll normalize the style, add a changelog, and push out a new build soon. Thanks for making the effort to add unit tests, and special thanks for your contribution, @ferboz ! |
Thank you @jquast to maintain open source! |
This is released to pypi as version 0.4.4. By use of your new unit tests, I adjusted the boundaries of your |
Previously 'retry' parameter match the absolute number of resend before failing.
With the fix 'retry' match the maximum number of resend a failed packet before failing