Macket messenger #130
Open
Macket messenger #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 7, 2017 13:58
tehnotrack
reviewed
Apr 22, 2017
| import java.util.LinkedList; | ||
|
|
||
| public class MyServer { | ||
| private static final int BUFSIZE = 100; |
There was a problem hiding this comment.
не жмитесь, сделайте буфер 2048 чтобы не иметь проблем с размером сообщения
| if (args.length != 1) { | ||
| throw new IllegalArgumentException("Parameter: <Port>"); | ||
| } | ||
| LinkedList<Integer> list = new LinkedList<>(); |
| Socket clntSock = serverSocket.accept(); | ||
| outs.addLast(clntSock.getOutputStream()); | ||
|
|
||
| Thread inThread = new Thread() { |
There was a problem hiding this comment.
Эти треды стоит где-то сохранять, чтобы потом можно было ими управлять.
Например список
|
|
||
| InputStream in = clntSock.getInputStream(); | ||
|
|
||
| while ((recvMsgSize = in.read(recieveBuf)) != -1) { |
There was a problem hiding this comment.
У вас работа с клиентом уже вынесена в поток. Вы же на каждое чтение заводите еще один новый поток на запись.
Либо оставьте запись в основном потоке либо заведите отдельный, но 1 и передавайте ткда данные через очередь
added 9 commits
May 4, 2017 16:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.