-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Changing the Bot to Event-Based #55
Conversation
- Create EventManager / IEventHandler - Moved out a bunch of the cell things into handlers
from cell_workers.utils import distance | ||
from events import IEventHandler | ||
|
||
class CachablePokemonHandler(IEventHandler): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty - I was thinking of cache. Note, this is still heavily WIP - I just wanted to add some progress
Mind providing a list of what's left to be worked on so other people can contribute? Awesome work so far :) |
@TheSavior can you join our slack and maybe discuss a bit about this? |
Sorry, didn't realize this was a different bot. I have no feelings about the approach you guys take, but I strongly don't think this is the right approach for the upstream bot. I have laid out the concerns that I have about it here: PokemonGoF/PokemonGo-Bot#706 The approach we want to go in to enable extensibility and configuration is using behavior trees PokemonGoF/PokemonGo-Bot#142 |
#67 - closed... |
NOTE: Still WIP
Short Description: Complete change of PokemonGoBot to utilize dynamically loaded events.
Changes:
TODO
@OpenPoGo/maintainers