Fix : Sonar issues (#74)

* renamed interface , removed unused import

* removed unused prop type

* removed unused import

* removed unused import

* useState call is  destructured into value + setter pair

* sonar cloud issue

* removed unused variableand import

* removed keycloak code

* Fix-Sonar issues

* Fix-Sonar issue

src/App.tsx

@@ -5,7 +5,6 @@ import guestRoutes from "./routes/GuestRoutes";
 import { Suspense, useEffect, useState } from "react";
 import Loader from "./components/common/Loader";
 import { BrowserRouter as Router, Routes, Route } from "react-router-dom";
-// import { useKeycloak } from "@react-keycloak/web";
 import { AuthProvider } from "./utils/context/checkToken";
 import "./assets/styles/App.css";
 import Layout from "./components/common/layout/Layout";
@@ -16,7 +15,6 @@ function App() {
     { path: string; component: React.ElementType }[]
   >([]);
   const token = localStorage.getItem("authToken");
-  // const { keycloak } = useKeycloak();
 
   useEffect(() => {
     if (token) {

src/components/ConfirmationDialog.tsx

@@ -24,7 +24,6 @@ interface ConfirmationDialogProps {
   handleConfirmation: () => Promise<void>;
   loading?: boolean;
   consentText?: string;
-  documents?: string[];
 }
 
 const ConfirmationDialog: React.FC<ConfirmationDialogProps> = ({
@@ -38,15 +37,13 @@ const ConfirmationDialog: React.FC<ConfirmationDialogProps> = ({
 
   consentText = consentText || t("CONFIRMATION_DIALOGUE_CONSENT_TEXT");
 
-  // Function to call the parent's function
   const sendCloseDialog = () => {
     closeDialog(false);
   };
 
   const openSubmitDialog = async () => {
     if (handleConfirmation) {
       handleConfirmation();
-      // navigate("/userprofile");
     }
   };
   const closeSubmitDialog = () => {
@@ -87,7 +84,6 @@ const ConfirmationDialog: React.FC<ConfirmationDialogProps> = ({
                 {consentText}
               </Text>
               <VStack>
-                {/* need to add new document list as per figma {loading ? <Loader /> : <DocumentList documents={documents} />} */}
                 {loading ? <Loader /> : <Text>List of documents</Text>}
               </VStack>
             </ModalBody>

src/components/WebView.tsx

@@ -1,4 +1,3 @@
-// import axios from "axios";
 import { useEffect, useRef } from "react";
 import { transformData } from "../utils/jsHelper/helper";
 import Layout from "./common/layout/Layout";

src/components/common/UserDetails.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect } from "react";
+import React from "react";
 import { Box, Text, HStack, VStack } from "@chakra-ui/react";
 import { useTranslation } from "react-i18next";
 import { formatDate } from "../../utils/jsHelper/helper";

src/components/common/input/DisabledInput.tsx

@@ -11,9 +11,6 @@ import { CheckIcon } from "@chakra-ui/icons";
 interface CustomSelectProps {
   label: string;
   placeholder?: string;
-  width?: string;
-  height?: string;
-  border?: string;
 }
 
 const CustomDisableInput: React.FC<CustomSelectProps> = ({

src/components/common/input/FloatingSelect.tsx

@@ -41,7 +41,7 @@ const FloatingSelect: React.FC<FloatingSelectProps> = ({
         px={1}
         transform={isFocused || value ? "scale(0.85)" : "translateY(-50%)"}
         transition="all 0.2s ease-out"
-        color={isFocused ? "gray.500" : "gray.500"}
+        color={"gray.500"}
         fontSize={isFocused || value ? "17px" : "16px"}
         zIndex={100}
         pointerEvents="none"

src/components/common/layout/Navbar.tsx

@@ -16,7 +16,6 @@ import {
 } from "@chakra-ui/react";
 import { HamburgerIcon } from "@chakra-ui/icons";
 import CustomSelect from "../input/Select";
-// import { useKeycloak } from "@react-keycloak/web";
 import { useNavigate } from "react-router-dom";
 import { useTranslation } from "react-i18next";
 import { logoutUser } from "../../../services/auth/auth";
@@ -27,9 +26,7 @@ const Navbar: React.FC<{ isMenu?: boolean }> = ({ isMenu = true }) => {
   const navigate = useNavigate();
   const { t } = useTranslation();
   const toast = useToast();
-  // const { keycloak } = useKeycloak();
   const handleLogout = async () => {
-    // keycloak.logout({ redirectUri: window.location.origin });
     try {
       const response = await logoutUser();
       if (response) {

src/screens/auth/SignUpWithPassword.tsx

@@ -37,8 +37,8 @@ const SignUpWithPassword: React.FC = () => {
   });
   const [confirmPassword, setConfirmPassword] = useState<string>("");
   const [loading, setLoading] = useState(false);
-  //   const [isFormValid, setIsFormValid] = useState<boolean>(false);
-  const [UserName, SetUserName] = useState<string>("");
+
+  const [userName, setUserName] = useState<string>("");
   const handleBack = () => {
     navigate(-1);
   };
@@ -82,7 +82,7 @@ const SignUpWithPassword: React.FC = () => {
       // Generate username based on available values
       const { firstName, lastName, phoneNumber } = updatedDetails;
 
-      SetUserName(
+      setUserName(
         `${firstName?.trim().toLowerCase() || ""}_${
           lastName?.charAt(0).toLowerCase() || ""
         }_${phoneNumber?.slice(-4) || ""}`
@@ -152,10 +152,10 @@ const SignUpWithPassword: React.FC = () => {
     const { firstName, lastName, phoneNumber } = userDetails;
 
     if (firstName && lastName && phoneNumber.length >= 6) {
-      const username = `${firstName}_${lastName?.charAt(
-        0
-      )}_${phoneNumber?.slice(-4)}`;
-      SetUserName(username);
+      const name = `${firstName}_${lastName?.charAt(0)}_${phoneNumber?.slice(
+        -4
+      )}`;
+      setUserName(name);
     }
   }, [userDetails.firstName, userDetails.lastName, userDetails.phoneNumber]);
   const validate = (phoneNumber) => {
@@ -217,11 +217,11 @@ const SignUpWithPassword: React.FC = () => {
               isInvalid={confirmPassword.trim() === ""}
               errorMessage={t("SIGNUP_CONFIRM_PASSWORD_IS_REQUIRED")}
             />
-            {UserName.length > 0 && (
+            {userName.length > 0 && (
               <Text textAlign="center" fontSize="14px" mt={4}>
                 {"Your username will be "}
                 <Text as="span" fontWeight="bold" color="#06164B">
-                  {UserName}
+                  {userName}
                 </Text>
               </Text>
             )}

src/screens/benefit/Details.tsx

@@ -5,7 +5,6 @@ import {
   Text,
   UnorderedList,
   ListItem,
-  useDisclosure,
   HStack,
   Icon,
   Modal,
@@ -83,7 +82,6 @@ interface WebFormProps {
 }
 
 const BenefitsDetails: React.FC = () => {
-  const { isOpen, onClose } = useDisclosure();
   const [context, setContext] = useState<FinancialSupportRequest | null>(null);
   const [item, setItem] = useState<BenefitItem | null>(null);
   const [loading, setLoading] = useState<boolean>(true);

src/services/benefit/benefits.tsx

@@ -1,5 +1,4 @@
 import axios, { AxiosError } from "axios";
-import { getToken } from "../auth/asyncStorage";
 import { generateUUID } from "../../utils/jsHelper/helper";
 const apiBaseUrl = import.meta.env.VITE_API_BASE_URL;
 const bap_id = import.meta.env.VITE_API_BASE_ID;
@@ -36,10 +35,10 @@ export const getAll = async (userData: {
  * Login a user
  * @param {Object} loginData - Contains phoneNumber, password
  */
-interface getOneParams {
+interface GetOneParams {
   id: string | undefined;
 }
-export const getOne = async ({ id }: getOneParams) => {
+export const getOne = async ({ id }: GetOneParams) => {
   const loginData = {
     context: {
       domain: "onest:financial-support",
@@ -207,7 +206,7 @@ export const confirmApplication = async ({
     handleError(error);
   }
 };
-interface createApplicationParams {
+interface CreateApplicationParams {
   user_id: string | undefined;
   benefit_id: string | undefined;
   benefit_provider_id: string | undefined;
@@ -217,7 +216,7 @@ interface createApplicationParams {
   status: string;
   application_data: unknown;
 }
-export const createApplication = async (data: createApplicationParams) => {
+export const createApplication = async (data: CreateApplicationParams) => {
   try {
     const token = localStorage.getItem("authToken");