Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register with password,login and logout API #21

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

vishnuvinay89
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

// password: string;
@ApiProperty({})
@IsNotEmpty({ message: 'Password is required' })
@MinLength(8, { message: 'Password must be at least 8 characters long' })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnuvinay89 Remove Password validation only keep minLength 4 characters, use below code


@ApiProperty({})
  @IsOptional()
  @MinLength(4, { message: 'Password must be at least 4 characters long' })
  password: string;

Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ManojNathIC ManojNathIC merged commit a97bda0 into tekdi:v0.1.6 Dec 3, 2024
1 of 2 checks passed
ManojNathIC added a commit that referenced this pull request Dec 3, 2024
* register with password,login and logout API

* changed password length

Co-authored-by: vishnuvinay89 <vishnu.vinay@tekditechnologies.com>
manojLondhe added a commit that referenced this pull request Dec 3, 2024
* register with password,login and logout API

* changed password length

* Update wallet_dev.yml

* Update uat-wallet.yml

* register with password,login and logout API (#21) (#22)

* register with password,login and logout API

* changed password length

Co-authored-by: vishnuvinay89 <vishnu.vinay@tekditechnologies.com>

* Update uat-wallet.yml

* Update wallet_dev.yml

* code changes for preview of upload/fetch document

---------

Co-authored-by: Sudeep Ratnaparkhe <58525720+sudeeppr1998@users.noreply.github.com>
Co-authored-by: Manoj L <manojLondhe@users.noreply.github.com>
Co-authored-by: Manoj Nath <66711855+ManojNathIC@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants