Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blog dengan judul dokumentasi api swagger laravel #140

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

Sigit-Wasis
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Jul 16, 2023

Deploy Preview for teknum ready!

Name Link
🔨 Latest commit 4c464c6
🔍 Latest deploy log https://app.netlify.com/sites/teknum/deploys/64b3f4087102f00008f56dcb
😎 Deploy Preview https://deploy-preview-140--teknum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kenapa ini masuk ke modified ya???

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kedetek hanya space di VS code secara Konten tidak ada perubahan

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herlangga72 it's ok kok. Di log https://github.com/teknologi-umum/blog/actions/runs/5436862119/jobs/9887007254 juga ada masalah prettier, gapapa kalo PR ini benerin itu.

Run npx prettier --check --ignore-path .gitignore .
Checking formatting...
[warn] content/top-5-programming-language-for-backend-web-programmers.md
[warn] Code style issues found in the above file. Forgot to run Prettier?
Error: Process completed with exit code 1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh ada errornya.. tadi gak lihat karena lihat notifnya dari email

Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good.

Tapi boleh file package-lock.json nya dihapus? Di repository ini kita pakainya pnpm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herlangga72 it's ok kok. Di log https://github.com/teknologi-umum/blog/actions/runs/5436862119/jobs/9887007254 juga ada masalah prettier, gapapa kalo PR ini benerin itu.

Run npx prettier --check --ignore-path .gitignore .
Checking formatting...
[warn] content/top-5-programming-language-for-backend-web-programmers.md
[warn] Code style issues found in the above file. Forgot to run Prettier?
Error: Process completed with exit code 1.

Comment on lines +36 to +38

# Package
package-lock.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seharusnya nggak perlu dimasukin ke .gitignore

@aldy505 aldy505 requested a review from elianiva July 16, 2023 13:44
Copy link
Contributor

@herlangga72 herlangga72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tinggal yg punya om reinaldy tadi aja sih

@Sigit-Wasis
Copy link
Author

halo @elianiva bagaimana adakah yang perlu di perbaiki ?

@elianiva elianiva merged commit 0d23411 into teknologi-umum:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants