-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for markdown #50
Conversation
The test passes locally, not sure why it returns as object |
tests/markdown.test.ts
Outdated
|
||
test('heading 1', () => { | ||
const code = detectLang('# Heading level 1'); | ||
assert.equal(code, 'Markdown'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please pull latest origin and change every assert.equal(code, 'Markdown')
to assert.equal(code.language, 'Markdown')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also can you please add more of a real-world markdown code? you can make your own or grab one online. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the tests and added more. It's hard not to have conflict because markdown can catch comments of all the other languages
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 24 +1
Lines 852 880 +28
Branches 43 43
=========================================
+ Hits 852 880 +28
Continue to review full report at Codecov.
|
About the skipped tests, can you replace those with a working test cases? Here's a few that I found on Github:
Thanks a lot |
I've made the changes requested. Let me know if more work is needed. Thanks |
Closes #20