Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: javascript arrow-function & window #53

Merged
merged 1 commit into from
Oct 13, 2021
Merged

improvement: javascript arrow-function & window #53

merged 1 commit into from
Oct 13, 2021

Conversation

semla
Copy link

@semla semla commented Oct 12, 2021

Closes #51
While Julia is still the answer for that snippet, it now gets closer to Javascript (and without the scripts tags, which are html, Javascript is detected).

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #53 (0387047) into master (86aaa2b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          897       901    +4     
  Branches        43        43           
=========================================
+ Hits           897       901    +4     
Impacted Files Coverage Δ
src/languages/javascript.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86aaa2b...0387047. Read the comment docs.

@aldy505 aldy505 requested a review from elianiva October 13, 2021 05:01
Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldy505 aldy505 merged commit d8b78cb into teknologi-umum:master Oct 13, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: JS/HTML wrongly detected
2 participants