-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rce): support multiple files #63
Conversation
Codecov ReportBase: 67.00% // Head: 69.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 67.00% 69.87% +2.87%
==========================================
Files 11 12 +1
Lines 700 737 +37
Branches 48 54 +6
==========================================
+ Hits 469 515 +46
+ Misses 199 191 -8
+ Partials 32 31 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This pull request introduces 1 alert when merging 58dffd3 into 88e3b8f - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuma stylistic changes
const missingParameters: string[] = []; | ||
if (req.body?.language === undefined || req.body?.language === null || typeof req.body.language !== "string" || req.body.language === "") { | ||
missingParameters.push("language"); | ||
} | ||
|
||
if (req.body?.version === undefined || req.body?.version === null || typeof req.body?.version !== "string" || req.body.version === "") { | ||
missingParameters.push("version"); | ||
} | ||
|
||
if (req.body?.code === undefined || req.body?.code === null || typeof req.body?.code !== "string" || req.body.code === "") { | ||
missingParameters.push("code"); | ||
} | ||
|
||
if (req.body?.compileTimeout !== undefined && req.body?.compileTimeout !== null && (typeof req.body.compileTimeout !== "number" || req.body.compileTimeout > 30_000)) { | ||
missingParameters.push("compileTimeout"); | ||
} | ||
|
||
if (req.body?.runTimeout !== undefined && req.body?.runTimeout !== null && (typeof req.body.runTimeout !== "number" || req.body.runTimeout > 30_000)) { | ||
missingParameters.push("runTimeout"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
puas banget lihat ini
code: string, | ||
entrypoint: boolean | ||
} | ||
|
||
/** | ||
* @generated from protobuf message rce.CodeRequest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ini file kalo udah bukan hasil codegen mending nanti rapihin aja deh sekalian wkwkw
tapi nanti aja beda PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nanti aja ini mah. masih ada yang hasil codegen juga
Co-authored-by: Dicha Zelianivan Arkana <dicha.arkana03@gmail.com>
Co-authored-by: Dicha Zelianivan Arkana <dicha.arkana03@gmail.com>
Closes #62