Add docs for secrets based on existing credentials #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
priyawadhwa
reviewed
Apr 25, 2022
docs/authentication.md
Outdated
| Set the namespace and name of the Kubernetes service account: | ||
|
|
||
| ```shell | ||
| export NAMESPACE=<your namespace> | ||
| export SERVICE_ACCOUNT_NAME=<service account name> | ||
| ``` | ||
|
|
||
| ### Create a Secret based on existing credentials | ||
|
|
||
| If you already ran `docker login`, you can copy the credentials into Kubernetes: |
There was a problem hiding this comment.
Can we add a step here where users confirm that the ~/.docker/config.json file is in this format?
{
"auths": {
"https://index.docker.io/v1/": {
"auth": "redacted"
}
}
on mac the dockerconfig uses keychain so it usually isn't in this format
There was a problem hiding this comment.
@priyawadhwa makes sense! Updated, PTAL 🙃
The current docs on "Authenticating to an OCI Registry" cover creating a secret by providing credentials on the command line but do not cover creating a secret based on existing credentials; this commit adds that.
concaf
force-pushed
the
concaf/docs/fix-authentication-oci
branch
from
f5c5e7e to
3d42d31
Compare
tekton-robot
added
size/M
priyawadhwa
approved these changes
Apr 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Thanks @concaf ! |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docs on "Authenticating to an OCI Registry" cover creating a
secret by providing credentials on the command line but do not cover
creating a secret based on existing credentials; this commit adds that.
Fixes #314
CC: @priyawadhwa