Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify provider and oidc issuer when requesting fulcio cert #440

Merged
merged 2 commits into from
May 5, 2022
Merged

Specify provider and oidc issuer when requesting fulcio cert #440

merged 2 commits into from
May 5, 2022

Conversation

priyawadhwa
Copy link
Contributor

Adds options for both of these to the config.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2022
@tekton-robot tekton-robot requested review from dlorenc and font May 4, 2022 19:45
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/signing/x509/x509.go 28.9% 25.0% -3.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/signing/x509/x509.go 28.9% 25.0% -3.9

@priyawadhwa priyawadhwa requested a review from mattmoor May 4, 2022 20:36
mattmoor
mattmoor reviewed May 4, 2022
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Lotta deps being pulled in here, I assume sigstore update? 🤔

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@priyawadhwa
Copy link
Contributor Author

Lotta deps being pulled in here, I assume sigstore update?

Yup, had to pull in cosign@main to be able to grab a specific provider!

@priyawadhwa
Copy link
Contributor Author

@mattmoor i think you might need to add an /approve as well!

@mattmoor
Copy link
Member

mattmoor commented May 5, 2022

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@tekton-robot tekton-robot merged commit ba26e6c into tektoncd:main May 5, 2022
@priyawadhwa priyawadhwa deleted the fulcio-spire branch May 5, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@dlorenc dlorenc Awaiting requested review from dlorenc

@font font Awaiting requested review from font

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyawadhwa @tekton-robot @mattmoor